Feat: add keypair generation command #817
Conversation
|
Hey, Don't worry about the failing build, it will go away with PHP 5.6 support in #816. |
bpolaszek
force-pushed
the
feature/keypair-generation
branch
from
8725313
to
5fcc610
Compare
bpolaszek
force-pushed
the
feature/keypair-generation
branch
from
5fcc610
to
dfa4861
Compare
bpolaszek
force-pushed
the
feature/keypair-generation
branch
4 times, most recently
from
9b47099
to
952322a
Compare
|
Thanks @chalasr 👍 |
chalasr
force-pushed
the
feature/keypair-generation
branch
from
0c9c411
to
a4c2d58
Compare
|
It took time, but here we go, this is in now. Thank you very much @bpolaszek. |
|
No worries / no hurries, thank you for taking the time to review this 🙂 |
|
Thanks for the feature! |
|
So this command will still use openssl to generate keypair? |
| */ | ||
| private $algorithm; | ||
|
|
||
| public function __construct(Filesystem $filesystem, string $secretKey, string $publicKey, ?string $passphrase, string $algorithm) |
There was a problem hiding this comment.
This breaks if either secretKey or publicKey are not set in the config, as the dep. injection / xml svc config will pass in NULL values and not ''.
I dunno anything about this bundle, but the doc seems to state that both secretKey and publicKey are optional...
Shall I file a ticket ?
Hello there,
I'd like to remove the most annoying part of the bundle installation: leverage openssl extension to generate the key pair in a one-liner 🙂
If you like this one, with the
-noption, we could update the flex recipe (unfamiliar with this, but I assume that's doable) so that public / private keys are generated on the fly duringcomposer install.Thoughts?
Ben