Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AbstractKeyLoader::getSigningKey() and AbstractKeyLoader::getPublicKey public. #832

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Make AbstractKeyLoader::getSigningKey() and AbstractKeyLoader::getPublicKey public. #832

merged 1 commit into from
Feb 9, 2021

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Feb 8, 2021 •
edited
Loading

This issue:

  • Make AbstractKeyLoader::getSigningKey() public instead of protected.
  • Make AbstractKeyLoader::getPublicKey() public instead of protected.
  • Update the interface KeyLoaderInterface with @method annotations.

Making them public instead of protected make possible the use of the very useful Decorator pattern.

Useful when one wants to replace one specific part of a bundle.

This PR relates to #831 but I would like to receive some feedback on this before merging.

@drupol drupol changed the base branch from master to 2.x February 8, 2021 16:47
@chalasr
Copy link
Collaborator

chalasr commented Feb 9, 2021 •
edited
Loading

Thanks for your work on this feature @drupol!

@chalasr chalasr merged commit 966f9b0 into lexik:2.x Feb 9, 2021
@drupol
Copy link
Contributor Author

drupol commented Feb 9, 2021

You're welcome, thanks for your reactivity !

@drupol drupol deleted the make-getPublickKey-and-getSigningKey-public branch February 9, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drupol @chalasr