Add WWW-Authenticate response header on 401 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, would you care to elaborate ? |
|
http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.2
|
|
Ok, it's pretty interesting. But the 'Bearer' authorization header value preffix cannot be hardcoded as it is configurable on a per-firewall basis. |
|
Actually, as far as I can tell, the "Bearer" part is standard (it's the same even for OAuth 2). It's only what follows that might vary. But we don't necessarily have to provide that flexibility for now... (Perhaps another PR for further enhancement?) |
|
I think you're right. Let's merge that for the moment. |
slashfan
added a commit
that referenced
this pull request
Aug 28, 2015
Add WWW-Authenticate response header on 401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.