Bundle breaks application if Symfony Console not installed #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges for the 'lexik_jwt_authentication.generate_keypair_command' service within the same conditional
chalasr
approved these changes
Aug 31, 2021
|
Thank you @yivi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the console command services are loaded only if
Symfony\Component\Console\Applicationexists, and later the extension attempts to modify the service defintion forlexik_jwt_authentication.generate_keypair_command(which would not be defined if Symfony Console is not installed), it can lead to breakage if Symfony Console is not installed.Moved both loading the services configuration file and the definition change to the same conditional.