Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of multiple public keys to verify tokens with a set of keys #928

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Add support of multiple public keys to verify tokens with a set of keys #928

merged 1 commit into from
Dec 8, 2021

Conversation

alexandre-daubois
Copy link
Contributor

@alexandre-daubois alexandre-daubois commented Sep 28, 2021

It may be convenient to use multiple public keys to verify token signature when using RS algorithm. It would allow to verify tokens coming from different providers.

Somehow related to #707

@alexandre-daubois alexandre-daubois changed the title feat: add support of multiple public keys to verify tokens with a set of keys Add support of multiple public keys to verify tokens with a set of keys Sep 28, 2021
@chalasr
Copy link
Collaborator

chalasr commented Oct 11, 2021

Thanks for the PR.
#707 is about allowing per-firewall configuration (including keys). Would that match your use case? Or do you need to support multiple keys for your entire application as this PR currently suggests?

@alexandre-daubois
Copy link
Contributor Author

Thanks for your reply! I don't think this would match our use case. Indeed, we would need to support multiple public keys for a single firewall. Tokens are coming from many providers, each with their own key, passing to a single firewall on a common endpoint.

@HidouriAnis
Copy link

HidouriAnis commented Oct 31, 2021

I currently have the same needs as you, what did you do as a solution?

@alexandre-daubois
Copy link
Contributor Author

@HidouriAnis for now, we did it like as it's in #707, in this comment. Even if this works, this is not super convenient to redefine all services like this. It's also very verbose.

@chalasr
Copy link
Collaborator

chalasr commented Dec 8, 2021

Thank you @alexandre-daubois.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants