Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove_token_from_body_when_cookies_used config option #940

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

TjorvenB
Copy link
Contributor

Added configuration and documentation for the argument added in #912. #912

@TjorvenB
Copy link
Contributor Author

Hello, is there something that is blocking this PR? If so, please let me know and I will make the required modifications.

Copy link
Collaborator

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor comment

Resources/doc/1-configuration-reference.md Outdated Show resolved Hide resolved
@chalasr
Copy link
Collaborator

chalasr commented Dec 5, 2021

This looks good. I'm going to merge it a bit later this month. Thank you!

@lwillems
Copy link

lwillems commented Dec 7, 2021

thx @TjorvenB and @chalasr needs it too ;)

@chalasr chalasr changed the title Config and documentation for Lexik#912 Add remove_token_from_body_when_cookies_used config option Dec 8, 2021
@chalasr
Copy link
Collaborator

chalasr commented Dec 8, 2021

Thank you @TjorvenB.

@chalasr chalasr merged commit e846d29 into lexik:2.x Dec 8, 2021
chalasr added a commit that referenced this pull request Dec 11, 2022
…_when_cookies_used` (usu)

This PR was merged into the 2.x branch.

Discussion
----------

allow environment variables for `remove_token_from_body_when_cookies_used`

#940 introduced a new config option to enable response body when cookies are used:

```yaml
remove_token_from_body_when_cookies_used: false
```

However, currently environment variables cannot be used to control this config. An error `Environment variables "bool:JWT_REMOVE_TOKEN_FROM_BODY" are never used` is thrown. After this PR, this option can also be used as following:

```yaml
remove_token_from_body_when_cookies_used: '%env(bool:JWT_REMOVE_TOKEN_FROM_BODY)%'
```

Commits
-------

376db99 allow environment variables for remove_token_from_body_when_cookies_used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants