fix getIterator compatible with php 8.1 #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerison
force-pushed
the
fix-getInterator-for-php-8.1
branch
from
e8ddd5d
to
ac542a9
Compare
chalasr
force-pushed
the
fix-getInterator-for-php-8.1
branch
from
ac542a9
to
bed4848
Compare
chalasr
reviewed
Dec 8, 2021
.github/workflows/ci.yml
Outdated
| - php: 8.1 | ||
| symfony: 6.0.*@dev | ||
| composer-flags: '' | ||
| can-fail: false |
There was a problem hiding this comment.
I'm reverting this changes as the CI is updated in #968.
composer.json
Outdated
| @@ -37,7 +37,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=7.1", | |||
| "php": "^7.1 || ^8.0", | |||
There was a problem hiding this comment.
I'm going to revert this as I prefer keeping it open.
phpunit.xml.dist
Outdated
| @@ -28,6 +28,6 @@ | |||
| </filter> | |||
|
|
|||
| <php> | |||
| <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=0&max[direct]=27"></env> | |||
| <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=17&max[direct]=27"></env> | |||
There was a problem hiding this comment.
I'm reverting this one as it should not be needed (deprecations should be fixed instead).
|
Thanks for fixing this bug @eerison. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.