Translate message errors

[flohw]

Hi @chalasr,

The exception messages are not translated even if the locale was set.
I largely copied inspired my code from this PR: symfony/symfony#38037 to translate the message.

Let me know if any changes need to be done.

[flohw]

I just noted that on the original PR translations are made in the authenticator. It may be a better choice as the listener can be changed by the developer.

Let me know if I missed something and should update to translate in the authenticators too or only in them.

Thank you

[EDIT] also, not sure why the tests fail...

[chalasr]

Thanks a lot for the PR. Here are some suggestions :)

[chalasr]

Don't worry about the failing tests, it's unrelated. I need to look into them, sorry about that.

[flohw]

Thank you for this quick review! I updated the code accordingly. (sorry for the multiple push force, I struggled with my gpg key...)

Also note about this comment above:

I just noted that on the original PR translations are made in the authenticator. It may be a better choice as the listener can be changed by the developer.

Let me know if I missed something and should update to translate in the authenticators too or only in them.

Should I update the other place where strtr is used?

[chalasr]

Sorry I was unsure to understand your question, got it now.
If you could do the same in the jwt authenticator that would be awesome (both are good, so what you already did is valid!)

[flohw]

Hi @chalasr,

Thanks I just added translator in both authenticators (JWT and JWTToken).

[flohw]

Hi @chalasr
I just saw the new release and rebase my branch.
The failing tests have changed. I am not sure if it's on my side to repair especially for the PHP8/SF5.3 couple.

Thanks

[chalasr]

No worries, it's due to a Symfony bug revealed by your changes. See symfony/symfony#44918 for the fix.

[chalasr]

Thanks @flohw for working on this feature, this is much appreciated.