Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Request object into AuthenticationFailureEvent #995

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

Dumra
Copy link

@Dumra Dumra commented Mar 16, 2022

Hey, @chalasr. Thanks for ur bundle.
Want to get the Request object in a subscriber for AuthenticationFailureEvents for passing some data regarding the occurred exception to e.g. symfony:terminate event subscriber .

Regards.

Copy link
Collaborator

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR! Here are some comments

Event/AuthenticationFailureEvent.php Outdated Show resolved Hide resolved
Event/AuthenticationFailureEvent.php Outdated Show resolved Hide resolved
Event/AuthenticationFailureEvent.php Outdated Show resolved Hide resolved
Event/AuthenticationFailureEvent.php Outdated Show resolved Hide resolved
Event/AuthenticationFailureEvent.php Show resolved Hide resolved
Event/AuthenticationFailureEvent.php Outdated Show resolved Hide resolved
@Dumra Dumra requested a review from chalasr March 16, 2022 17:58
Copy link
Collaborator

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chalasr chalasr force-pushed the add_request_object_into_auth_failed_events branch from 7c4df79 to 4be0404 Compare March 16, 2022 18:31
@chalasr
Copy link
Collaborator

chalasr commented Mar 16, 2022

Thank you @Dumra.

@chalasr chalasr merged commit 1bf2a3b into lexik:2.x Mar 16, 2022
@chalasr
Copy link
Collaborator

chalasr commented Mar 16, 2022

This should be released in a week or so (I just have a change of mine to finish beforehand). Feel free to require 2.x-dev meanwhile, and take care of yourself :) #StandWithUkraine

@Dumra
Copy link
Author

Dumra commented Mar 16, 2022

Sounds great!
Thank you for u support!

@Dumra
Copy link
Author

Dumra commented Mar 25, 2022

Hey, @chalasr .
When're u go' to create a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants