Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Add compatibility of symfony 4 #72

Merged
merged 14 commits into from
Nov 24, 2017
Merged

Add compatibility of symfony 4 #72

merged 14 commits into from
Nov 24, 2017

Conversation

aivus
Copy link
Contributor

@aivus aivus commented Nov 18, 2017

Depends on #71

#SymfonyConHackday2017

@gilles-g
Copy link
Member

ping @aivus
Could you try to fix conflict? if test are ok I will merge it.
Thanks :)

@gilles-g gilles-g self-requested a review November 22, 2017 13:41
@aivus
Copy link
Contributor Author

aivus commented Nov 22, 2017

@Spike31 I'll fix them in few days

@aivus aivus changed the title [WIP] Add compatibility of symfony 4 Add compatibility of symfony 4 Nov 23, 2017
@aivus
Copy link
Contributor Author

aivus commented Nov 23, 2017

@Spike31 ready to review

@gilles-g gilles-g merged commit 4b8a990 into lexik:master Nov 24, 2017
@aivus aivus deleted the add-compatibility-symfony-4 branch November 24, 2017 09:07
@aivus
Copy link
Contributor Author

aivus commented Nov 24, 2017

@Spike31 Symfony 4 introduces some changes related to new DI logic.
At least related to the registering of commands.

I'll test and add changes if they will be required.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants