Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Handle multiple paybox accounts #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sarramegnag
Copy link

@sarramegnag sarramegnag commented Nov 20, 2017

Greetings,

Huge PR related to #89.
Unfortunatly I think it would be too hard to handle backward compatibility.

Thanks for your review and feel free to ask if you have any questions.

Regards,

Guillaume

@acidjames
Copy link
Collaborator

@Spike31 Is this PR worth a v3 tag ?

(i've changed jobs now and i won't be able to continue support on this plugin unfortunately but i think this PR is worth some investigation)

James

@sarramegnag
Copy link
Author

Just for the information, we're using my fork in production since one year and a half. No problem until now with direct payments (we're not using recurring payments).

@gilles-g
Copy link
Member

Well...
Handle multiple accounts is not common.

I'm not sure this is a feature we would like to see.

Or create an other bundle with a dps on that bundle, i don't know.
Maybe we can mention your fork on the documentation, just in case

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants