Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trial): avoid rule id conflict #2539

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

ngjaying
Copy link
Collaborator

@ngjaying ngjaying commented Jan 8, 2024

Rule id is part of many id, conflict between multiple trial rules or real rule may happen. Add a prefix and uuid for each trial rule runtime id.

Rule id is part of many id, conflict between multiple trial rules or real rule may happen. Add a prefix and uuid for each trial rule runtime id.

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 172 lines in your changes are missing coverage. Please review.

Comparison is base (923d258) 62.74% compared to head (9f4e819) 62.92%.
Report is 17 commits behind head on master.

Files Patch % Lines
internal/converter/json/converter.go 69.39% 77 Missing and 24 partials ⚠️
internal/binder/function/funcs_math.go 70.25% 37 Missing and 10 partials ⚠️
internal/topo/planner/lookupPlan.go 70.83% 6 Missing and 1 partial ⚠️
internal/topo/node/source_pool.go 68.42% 4 Missing and 2 partials ⚠️
internal/trial/run.go 71.43% 6 Missing ⚠️
internal/io/websocket/websocket_sink.go 66.67% 2 Missing and 1 partial ⚠️
internal/topo/context/decoder.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2539      +/-   ##
==========================================
+ Coverage   62.74%   62.92%   +0.18%     
==========================================
  Files         308      308              
  Lines       36551    36865     +314     
==========================================
+ Hits        22932    23197     +265     
- Misses      11519    11546      +27     
- Partials     2100     2122      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review January 8, 2024 07:05
@ngjaying ngjaying requested a review from Yisaer January 8, 2024 07:05
@ngjaying ngjaying merged commit 1dc8392 into lf-edge:master Jan 8, 2024
56 checks passed
ngjaying added a commit to ngjaying/kuiper that referenced this pull request Jan 9, 2024
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
ngjaying added a commit that referenced this pull request Jan 9, 2024
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants