Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(component): extract import/export manager #2551

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

ngjaying
Copy link
Collaborator

No description provided.

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 375 lines in your changes are missing coverage. Please review.

Comparison is base (1a6fdf5) 62.96% compared to head (fb8a403) 62.66%.

Files Patch % Lines
internal/server/import_export.go 38.99% 281 Missing and 21 partials ⚠️
internal/server/schema_init.go 0.00% 13 Missing ⚠️
internal/server/plugin_init.go 0.00% 12 Missing ⚠️
internal/server/service_init.go 0.00% 12 Missing ⚠️
internal/server/portable_init.go 0.00% 11 Missing ⚠️
internal/server/rule_migration.go 0.00% 10 Missing ⚠️
internal/schema/registry.go 0.00% 8 Missing ⚠️
internal/plugin/native/manager.go 0.00% 5 Missing ⚠️
internal/server/server.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2551      +/-   ##
==========================================
- Coverage   62.96%   62.66%   -0.30%     
==========================================
  Files         308      309       +1     
  Lines       36877    36943      +66     
==========================================
- Hits        23217    23148      -69     
- Misses      11540    11673     +133     
- Partials     2120     2122       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review January 10, 2024 10:27
@ngjaying ngjaying requested a review from Yisaer January 10, 2024 10:27
@ngjaying ngjaying merged commit a54eeb7 into lf-edge:master Jan 11, 2024
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants