Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support more kv functions #2575

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

rextang
Copy link
Contributor

@rextang rextang commented Jan 22, 2024

Add kvpair_array_to_obj and obj_to_kvpair_array

Closes #2530

Signed-off-by: Rex Tang <rextang@foxmail.com>
Signed-off-by: Rex Tang <rextang@foxmail.com>
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (238685c) 63.00% compared to head (397b717) 63.02%.

Files Patch % Lines
internal/binder/function/funcs_array.go 73.91% 4 Missing and 2 partials ⚠️
internal/binder/function/funcs_obj.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2575      +/-   ##
==========================================
+ Coverage   63.00%   63.02%   +0.02%     
==========================================
  Files         316      316              
  Lines       37518    37556      +38     
==========================================
+ Hits        23638    23669      +31     
- Misses      11736    11741       +5     
- Partials     2144     2146       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying requested a review from Yisaer January 24, 2024 01:08
@ngjaying ngjaying changed the title feat: support kvpair_array_to_obj and obj_to_kvpair_array functions feat: support more kv functions Jan 24, 2024
@ngjaying ngjaying merged commit 21e1366 into lf-edge:master Jan 24, 2024
60 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More array and object functions
3 participants