-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support neuron/kafka ping #2591
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2591 +/- ##
==========================================
+ Coverage 63.76% 63.83% +0.06%
==========================================
Files 327 327
Lines 37987 38005 +18
==========================================
+ Hits 24222 24257 +35
+ Misses 11600 11583 -17
Partials 2165 2165 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request to add ut. If hard to setup external connection, at least test ping failure case.
Signed-off-by: Song Gao <disxiaofei@163.com>
No description provided.