Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support neuron/kafka ping #2591

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jan 29, 2024

No description provided.

Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer changed the title feat: revise neuron ping feat: support neuron/kafka ping Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b977ca3) 63.76% compared to head (d8581c0) 63.83%.
Report is 3 commits behind head on master.

Files Patch % Lines
internal/io/neuron/source.go 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2591      +/-   ##
==========================================
+ Coverage   63.76%   63.83%   +0.06%     
==========================================
  Files         327      327              
  Lines       37987    38005      +18     
==========================================
+ Hits        24222    24257      +35     
+ Misses      11600    11583      -17     
  Partials     2165     2165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to add ut. If hard to setup external connection, at least test ping failure case.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying January 31, 2024 06:48
@ngjaying ngjaying merged commit be43e35 into lf-edge:master Jan 31, 2024
55 checks passed
@Yisaer Yisaer deleted the revise_neuron_ping branch January 31, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants