Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix TestPing test #2595

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix: fix TestPing test #2595

merged 1 commit into from
Jan 30, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jan 30, 2024

No description provided.

Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying January 30, 2024 07:07
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (d02721d) 63.08% compared to head (754cb33) 63.77%.
Report is 9 commits behind head on master.

Files Patch % Lines
internal/topo/planner/planner.go 65.85% 21 Missing and 7 partials ⚠️
internal/io/mock/test_source_connector.go 78.72% 10 Missing ⚠️
internal/topo/planner/planner_graph.go 75.61% 9 Missing and 1 partial ⚠️
pkg/infra/saferun.go 23.08% 10 Missing ⚠️
internal/topo/node/decode_op.go 89.89% 7 Missing and 2 partials ⚠️
internal/topo/subtopo.go 88.57% 6 Missing and 2 partials ⚠️
internal/topo/topo.go 80.00% 8 Missing ⚠️
internal/io/mqtt/mqtt_source_connector.go 89.83% 4 Missing and 2 partials ⚠️
internal/io/http/rest_sink.go 0.00% 3 Missing ⚠️
internal/binder/function/funcs_obj.go 0.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2595      +/-   ##
==========================================
+ Coverage   63.08%   63.77%   +0.69%     
==========================================
  Files         320      327       +7     
  Lines       37496    37987     +491     
==========================================
+ Hits        23653    24226     +573     
+ Misses      11703    11598     -105     
- Partials     2140     2163      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yisaer Yisaer changed the title fix: fix test fix: fix TestPing test Jan 30, 2024
@ngjaying ngjaying merged commit b977ca3 into lf-edge:master Jan 30, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants