Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(xsql): unify row and collection #2700

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

ngjaying
Copy link
Collaborator

  • Each node now only needs to handle two kinds of data Row/Collection. Other data may be error, watermark, barrier

@ngjaying ngjaying force-pushed the 114 branch 2 times, most recently from 88ebf5e to d5bb84f Compare March 13, 2024 02:46
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 74.34211% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 63.48%. Comparing base (30bf65f) to head (b02c3a4).
Report is 1 commits behind head on master.

Files Patch % Lines
internal/topo/operator/project_operator.go 68.00% 5 Missing and 3 partials ⚠️
internal/xsql/collection.go 66.67% 8 Missing ⚠️
internal/topo/node/join_align_node.go 61.54% 4 Missing and 1 partial ⚠️
internal/topo/node/switch_node.go 50.00% 4 Missing and 1 partial ⚠️
internal/topo/operator/join_operator.go 66.67% 4 Missing ⚠️
internal/xsql/sorter.go 60.00% 3 Missing and 1 partial ⚠️
internal/topo/operator/analyticfuncs_operator.go 50.00% 2 Missing ⚠️
internal/topo/operator/func_operator.go 0.00% 2 Missing ⚠️
internal/topo/node/lookup_node.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2700      +/-   ##
==========================================
+ Coverage   63.46%   63.48%   +0.03%     
==========================================
  Files         337      338       +1     
  Lines       38899    38936      +37     
==========================================
+ Hits        24684    24718      +34     
- Misses      12050    12053       +3     
  Partials     2165     2165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying force-pushed the 114 branch 3 times, most recently from 49743e5 to a53243f Compare March 13, 2024 05:53
@ngjaying ngjaying added this to the 1.14 milestone Mar 15, 2024
@ngjaying ngjaying marked this pull request as ready for review March 18, 2024 02:00
@ngjaying ngjaying requested a review from Yisaer March 18, 2024 03:53
- Each node now only needs to handle two kinds of data Row/Collection. Other data may be error, watermark, barrier

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying merged commit 68df343 into lf-edge:master Mar 21, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants