Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix describe rule exposes password #2732

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Mar 25, 2024

No description provided.

Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying March 25, 2024 08:06
Signed-off-by: yisaer <disxiaofei@163.com>
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 63.50%. Comparing base (4917799) to head (935048c).
Report is 3 commits behind head on master.

Files Patch % Lines
internal/server/rest.go 55.56% 6 Missing and 2 partials ⚠️
pkg/hidden/hidden.go 87.88% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2732      +/-   ##
==========================================
- Coverage   63.51%   63.50%   -0.00%     
==========================================
  Files         339      339              
  Lines       38940    38974      +34     
==========================================
+ Hits        24730    24750      +20     
- Misses      12040    12056      +16     
+ Partials     2170     2168       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying merged commit bd89543 into lf-edge:master Mar 26, 2024
59 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Mar 29, 2024
Signed-off-by: yisaer <disxiaofei@163.com>
ngjaying pushed a commit that referenced this pull request Mar 29, 2024
Signed-off-by: yisaer <disxiaofei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants