Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check rule exists before create #2741

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Mar 27, 2024

No description provided.

Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying March 27, 2024 03:17
Signed-off-by: yisaer <disxiaofei@163.com>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 63.55%. Comparing base (520570e) to head (dd295d2).
Report is 1 commits behind head on master.

Files Patch % Lines
internal/server/rule_manager.go 55.56% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2741      +/-   ##
==========================================
+ Coverage   63.51%   63.55%   +0.04%     
==========================================
  Files         340      340              
  Lines       39016    39024       +8     
==========================================
+ Hits        24780    24799      +19     
+ Misses      12067    12056      -11     
  Partials     2169     2169              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: yisaer <disxiaofei@163.com>
internal/server/rule_manager.go Outdated Show resolved Hide resolved
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying March 27, 2024 08:48
@ngjaying ngjaying merged commit b943ec6 into lf-edge:master Mar 27, 2024
58 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Mar 29, 2024
Signed-off-by: yisaer <disxiaofei@163.com>
ngjaying pushed a commit that referenced this pull request Mar 29, 2024
Signed-off-by: yisaer <disxiaofei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants