Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support fileDir notify source #3380

Merged
merged 13 commits into from
Nov 26, 2024
Merged

feat: support fileDir notify source #3380

merged 13 commits into from
Nov 26, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Nov 15, 2024

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 74.05063% with 41 lines in your changes missing coverage. Please review.

Project coverage is 71.16%. Comparing base (d2fe6b4) to head (2fd8f12).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/io/dirwatch/source.go 73.89% 31 Missing and 10 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3380    +/-   ##
========================================
  Coverage   71.16%   71.16%            
========================================
  Files         406      407     +1     
  Lines       46406    46573   +167     
========================================
+ Hits        33023    33142   +119     
- Misses      10797    10834    +37     
- Partials     2586     2597    +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer marked this pull request as ready for review November 22, 2024 01:50
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
internal/io/dirwatch/source.go Outdated Show resolved Hide resolved
internal/io/dirwatch/source.go Show resolved Hide resolved
internal/io/dirwatch/source.go Outdated Show resolved Hide resolved
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@ngjaying ngjaying merged commit 1d93d7e into lf-edge:master Nov 26, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants