Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support incremental hopping window #3386

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Nov 20, 2024

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.21%. Comparing base (410f52d) to head (2d1de7e).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/topo/node/window_inc_agg_op.go 97.37% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3386      +/-   ##
==========================================
+ Coverage   71.08%   71.21%   +0.13%     
==========================================
  Files         403      406       +3     
  Lines       46080    46469     +389     
==========================================
+ Hits        32754    33090     +336     
- Misses      10753    10794      +41     
- Partials     2573     2585      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying November 22, 2024 04:32
internal/topo/node/window_inc_agg_op.go Outdated Show resolved Hide resolved
@ngjaying ngjaying merged commit e8715d4 into lf-edge:master Nov 26, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants