Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite duration in conf #3387

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Nov 20, 2024

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 77.08333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 71.14%. Comparing base (410f52d) to head (8d7e720).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/server/bump/bump4.go 53.85% 8 Missing and 4 partials ⚠️
internal/server/bump/bump_manager.go 25.00% 4 Missing and 2 partials ⚠️
pkg/replace/replace.go 92.45% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3387      +/-   ##
==========================================
+ Coverage   71.08%   71.14%   +0.06%     
==========================================
  Files         403      404       +1     
  Lines       46080    46147      +67     
==========================================
+ Hits        32754    32828      +74     
+ Misses      10753    10748       -5     
+ Partials     2573     2571       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Yisaer Yisaer marked this pull request as ready for review November 20, 2024 07:33
@ngjaying ngjaying merged commit 2e5c33f into lf-edge:master Nov 20, 2024
58 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Nov 22, 2024
Signed-off-by: Song Gao <disxiaofei@163.com>
ngjaying pushed a commit that referenced this pull request Nov 22, 2024
Signed-off-by: Song Gao <disxiaofei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants