You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main purpose of this PR is to update the indirect dependency on Focinfi/go-dns-resolver package. The previous version of this package was missing license. Also, github.com/rackn/gohai disappeared from go.sum as expected.
Also run go mod tidy for both packages and go mod vendor additionally for newlog
edgeview does not use vendoring - @naiming-zededa do we want to keep it like that or unify it with pillar and newlog? I believe vendoring is used only to shorten the container build time.
The main purpose of this PR is to update the indirect dependency on
Focinfi/go-dns-resolver package. The previous version of this package
was missing license.
Also run 'go mod tidy' for both packages and 'go mod vendor'
additionally for newlog (edgeview does not use vendoring).
Signed-off-by: Milan Lenco <milan@zededa.com>
@milan-zededa I think the current way is fine. when update for edgeview is needed from pillar, it can update the go.mod instead of copying all the vendor files. thanks.
@milan-zededa I think the current way is fine. when update for edgeview is needed from pillar, it can update the go.mod instead of copying all the vendor files. thanks. @naiming-zededa@milan-zededa
FYI in #2861 we are trying to run the build without network access as a way of being able to better track which packages (golang, alpine, etc) so that it is easier to track the Software Bill of Materials for a build/release.
That implies that each pkg/foo needs to be more self contained. Hence having a vendor directory with the needed source (which go mod vendor will create). So I think we need such a PR for edgeview.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to update the indirect dependency on
Focinfi/go-dns-resolverpackage. The previous version of this package was missing license. Also,github.com/rackn/gohaidisappeared fromgo.sumas expected.Also run
go mod tidyfor both packages andgo mod vendoradditionally for newlogedgeview does not use vendoring - @naiming-zededa do we want to keep it like that or unify it with pillar and newlog? I believe vendoring is used only to shorten the container build time.
Signed-off-by: Milan Lenco milan@zededa.com