-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0 stable] Implement propagation of IP routes into apps via DHCP #3831
Conversation
Signed-off-by: Milan Lenco <milan@zededa.com>
Signed-off-by: Milan Lenco <milan@zededa.com> (cherry picked from commit 5e3bfb5)
Static and connected routes of network instances can be propagated to applications using DHCP option 121. Signed-off-by: Milan Lenco <milan@zededa.com> (cherry picked from commit a28d81d)
Signed-off-by: Milan Lenco <milan@zededa.com> (cherry picked from commit cf3dbde)
@uncleDecart I had to update EVE APIs in 11.0 and it brought also some patch envelopes changes. Hopefully it does not break anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check whether there are other API additions which arrive with this and in particular whether there was some api_capability value defined between 11.0.X and the route propagation one?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 11.0-stable #3831 +/- ##
===============================================
+ Coverage 20.33% 20.58% +0.24%
===============================================
Files 212 211 -1
Lines 46085 46348 +263
===============================================
+ Hits 9373 9540 +167
- Misses 36030 36112 +82
- Partials 682 696 +14 ☔ View full report in Codecov by Sentry. |
Luckily there were no API capabilities added between what 11.0 has and the route propagation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@milan-zededa patch envelopes support is not (fully) introduced in 11.0, so it should be fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It was strongly requested to make the propagation of static/connected IP routes available in the EVE 11.0 LTS version. This PR must therefore break the rule of not backporting new features (hopefully a one-time exception).
Original PR with the description of the feature: #3690