Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0 stable] Implement propagation of IP routes into apps via DHCP #3831

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

milan-zededa
Copy link
Contributor

@milan-zededa milan-zededa commented Mar 21, 2024

It was strongly requested to make the propagation of static/connected IP routes available in the EVE 11.0 LTS version. This PR must therefore break the rule of not backporting new features (hopefully a one-time exception).

Original PR with the description of the feature: #3690

Signed-off-by: Milan Lenco <milan@zededa.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit 5e3bfb5)
Static and connected routes of network instances can be propagated to
applications using DHCP option 121.

Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit a28d81d)
Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit cf3dbde)
@milan-zededa
Copy link
Contributor Author

@uncleDecart I had to update EVE APIs in 11.0 and it brought also some patch envelopes changes. Hopefully it does not break anything.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check whether there are other API additions which arrive with this and in particular whether there was some api_capability value defined between 11.0.X and the route propagation one?

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 58.18713% with 143 lines in your changes are missing coverage. Please review.

Project coverage is 20.58%. Comparing base (9b7759d) to head (69f1bfa).

Files Patch % Lines
pkg/pillar/nireconciler/linux_config.go 64.73% 46 Missing and 15 partials ⚠️
pkg/pillar/cmd/zedagent/parseconfig.go 0.00% 37 Missing ⚠️
pkg/pillar/nireconciler/genericitems/dnsmasq.go 72.07% 29 Missing and 2 partials ⚠️
pkg/pillar/types/zedroutertypes.go 0.00% 6 Missing ⚠️
pkg/pillar/dpcreconciler/genericitems/dhcpcd.go 28.57% 5 Missing ⚠️
pkg/pillar/cmd/zedagent/reportinfo.go 0.00% 1 Missing ⚠️
pkg/pillar/dpcreconciler/linux.go 0.00% 0 Missing and 1 partial ⚠️
pkg/pillar/nireconciler/linux_acl.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           11.0-stable    #3831      +/-   ##
===============================================
+ Coverage        20.33%   20.58%   +0.24%     
===============================================
  Files              212      211       -1     
  Lines            46085    46348     +263     
===============================================
+ Hits              9373     9540     +167     
- Misses           36030    36112      +82     
- Partials           682      696      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milan-zededa
Copy link
Contributor Author

milan-zededa commented Mar 22, 2024

Can you check whether there are other API additions which arrive with this and in particular whether there was some api_capability value defined between 11.0.X and the route propagation one?

Luckily there were no API capabilities added between what 11.0 has and the route propagation.
API update brought few patch envelopes additions (metrics). But as I understand it, it has no effect on what is implemented in 11.0 for this feature.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uncleDecart
Copy link
Member

@milan-zededa patch envelopes support is not (fully) introduced in 11.0, so it should be fine

Copy link
Member

@uncleDecart uncleDecart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit e8ef825 into lf-edge:11.0-stable Mar 25, 2024
44 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants