Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub/rootfs.cfg: add 'isolate CPU0 (only for PREEMPT_RT)' menu option #3875

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

rouming
Copy link
Contributor

@rouming rouming commented Apr 22, 2024

This will set the 'isolcpus=inverse,0 nohz_full=inverse,0' kernel command line, which by default pins all the service tasks running on EVE to the CPU0, isolating other CPUs to VM needs and prevents scheduling interference.

This command line uses the 'inverse' flag, which was introduced here:

lf-edge/eve-kernel#90

Now the configuration is general and does not depend on the number of CPUs. This option makes sense to set for the PREEMPT_RT kernel, which uses the 'inverse' flag.

XXX kernel version for RT is not yet updated, build server is gone, this change will follow.

This will set the 'isolcpus=inverse,0 nohz_full=inverse,0' kernel command
line, which by default pins all the service tasks running on EVE to the
CPU0, isolating other CPUs to VM needs and prevents scheduling interference.

This command line uses the 'inverse' flag, which was introduced here:

   lf-edge/eve-kernel#90

Now the configuration is general and does not depend on the number of CPUs.
This option makes sense to set for the PREEMPT_RT kernel, which uses the
'inverse' flag.

Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
@rouming rouming requested a review from rene as a code owner April 22, 2024 15:37
Copy link
Contributor

@rene rene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but do you want to mark this as a draft until you can get the new kernel built and hash updated?

@eriknordmark eriknordmark merged commit 6a21ca2 into lf-edge:master Apr 25, 2024
28 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants