newlog: fix file naming for logs #4491
Conversation
github-actions
bot
requested review from
christoph-zededa and
naiming-zededa
More specifically, the error was a log.Fatal from loguploader after the fallback to the old version of EVE. |
docs/LOGGING.md
Outdated
| @@ -115,7 +116,7 @@ The uploading is controlled on a scheduled timer. When the timer fires, the "log | |||
|
|
|||
| The "loguploader" collects stats of round-trip delay, controller CPU load percentage and log batch processing time. The current EVE implementation does not use those stats in calculating the uploading timer values. | |||
|
|
|||
| The already uploaded gzip files with app logs are moved to /persist/newlog/keepSentQueue directory or removed in case of dev.log.upload files. | |||
| The already uploaded gzip files with app logs are moved to /persist/newlog/keepSentQueue directory or removed in case of dev.log files. | |||
There was a problem hiding this comment.
All 'dev.log*' named files can not be removed. can they?
There was a problem hiding this comment.
I think they have a copy in the 'keep' directory already in the latest newlog change. so they should be removed.
There was a problem hiding this comment.
@naiming-zededa is right, but I understand that the sentence is confusing - I'll rewrite
Revert the file naming inside devUpload and keepSentQueue directories to the original format `dev.log.<timestamp>.gz` to keep the compatibility with previous versions of the newlogd. Signed-off-by: Paul Gaiduk <paulg@zededa.com>
europaul
force-pushed
the
logs-naming-safe-to-fallback
branch
from
8e46902 to
0949315
Compare
There was a problem hiding this comment.
Good that it fixes the current problem. Let's merge it soon.
But could we add some logic on top to avoid fatals with log formats in the future? For example, not ending up with a log.Fatal because of invalid log names, or maybe some cleanup logic to remove problematic files on request? I’m not sure where exactly this would fit, but just an idea...
Yes, but please lets do that as a separate PR. |
Revert the file naming inside devUpload and keepSentQueue directories to the original format
dev.log.<timestamp>.gzto keep the compatibility with previous versions of the newlogd.This is necessary e.g. in cases when EVE goes through an unsuccessful update and has to fallback to a version before the new naming convention. This way the logic inside newlogd, loguploader and edge-view can still understand the log files inside
/persist/newlogand not throw an error.