Kubevirt: Defer eve reboot/shutdown/update until drain completes #4494
+211,189
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An odd yetus failure, not sure what to make of this. |
github-actions
bot
requested review from
deitch,
eriknordmark,
milan-zededa,
OhmSpectator,
rouming and
uncleDecart
andrewd-zededa
force-pushed
the
drain-node
branch
from
3c4957b to
9caa356
Compare
andrewd-zededa
force-pushed
the
drain-node
branch
2 times, most recently
from
c65f122 to
465e6a0
Compare
As a part of kubevirt-eve we have multiple cluster nodes each hosting app workloads and volume replicas. This implements defer for eve mgmt operations which will result in unavailability of storage replicas. An example: 1. Node 1 outage and recovers. 2. Before volumes complete rebuilding on node 1: Node 2 outage and recovery. 3. Volumes begin rebuilding replicas on nodes 1 and 2. 4. User initiated request to reboot/shutdown/update eve-os on node3. 5. That config request is set to defer until replicas are rebuilt on the other nodes. Signed-off-by: Andrew Durbin <andrewd@zededa.com>
tidy, vendor, ... Signed-off-by: Andrew Durbin <andrewd@zededa.com>
andrewd-zededa
force-pushed
the
drain-node
branch
from
465e6a0 to
e3d900e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of kubevirt-eve we have multiple cluster nodes each
hosting app workloads and volume replicas. This implements defer
for eve mgmt config operations which will result in unavailability of storage
replicas. An example:
As a part of node drain all new node workloads are gated on that node with a cordon. The removal of that gate is managed by zedkube nodeOnBootHealthStatusWatcher() which waits until the local kubernetes node comes online/ready for the first time on each boot event and uncordons it.
For eve baseos image updates: this path waits until a new baseos image is available locally (LOADED or INSTALLED) and activated before beginning drain.