🧑🎄🧑🎄🧑🎄 Makefile: Bump linuxkit to version 1.5.3 🎄🎄🎄 #4495
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rene
force-pushed
the
bump-linuxkit
branch
2 times, most recently
from
5daf174 to
d8ff872
Compare
Bump linuxkit to version 1.5.3 in order to get a new feature that supports --tag in build.yml. This version also introduces some changes that requires some adjusts in the Makefile: 1. Introduces different verbose levels (this commit sets to level 2 to keep the same amount of information provided by the current version) 2. Remove --arch parameter from cache command (in favor of a --platform docker style parameter) Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
deitch
approved these changes
Dec 24, 2024
| @@ -535,7 +535,7 @@ $(BSP_IMX_PART): PKG=bsp-imx | |||
| $(EFI_PART) $(BOOT_PART) $(INITRD_IMG) $(IPXE_IMG) $(BIOS_IMG) $(UBOOT_IMG) $(BSP_IMX_PART): $(LINUXKIT) | $(INSTALLER) | |||
| mkdir -p $(dir $@) | |||
| $(LINUXKIT) pkg build --pull --platforms linux/$(ZARCH) pkg/$(PKG) # running linuxkit pkg build _without_ force ensures that we either pull it down or build it. | |||
| cd $(dir $@) && $(LINUXKIT) cache export --arch $(DOCKER_ARCH_TAG) --format filesystem --outfile - $(shell $(LINUXKIT) pkg show-tag pkg/$(PKG)) | tar xvf - $(notdir $@) | |||
| cd $(dir $@) && $(LINUXKIT) cache export --platform linux/$(DOCKER_ARCH_TAG) --format filesystem --outfile - $(shell $(LINUXKIT) pkg show-tag pkg/$(PKG)) | tar xvf - $(notdir $@) | |||
There was a problem hiding this comment.
Should we do the same change here?
Line 24 in 7832e62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🎄🧑🎄🧑🎄 Christmas PR 🎄🎄🎄
Bump linuxkit to version 1.5.3 in order to get a new feature that supports --tag in build.yml.