Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid nil dereference in baseosmgr #4563

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Avoid nil dereference in baseosmgr #4563

merged 1 commit into from
Jan 31, 2025

Conversation

rucoder
Copy link
Contributor

@rucoder rucoder commented Jan 30, 2025 •
edited
Loading

@rucoder rucoder requested a review from deitch as a code owner January 30, 2025 14:04
@github-actions github-actions bot requested a review from eriknordmark January 30, 2025 14:04
@rucoder rucoder added the stable Should be backported to stable release(s) label Jan 30, 2025
deitch
deitch approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you now want to have the contentID in the message? Or is it already there from higher up the stack?

@rucoder rucoder force-pushed the rucoder/nil-in-downloader branch from c2cb660 to 35b570b Compare January 30, 2025 14:18
@github-actions github-actions bot requested a review from deitch January 30, 2025 14:18
@rucoder
Copy link
Contributor Author

rucoder commented Jan 30, 2025

Do you now want to have the contentID in the message? Or is it already there from higher up the stack?

@deitch yeah, probably. fixed now

deitch
deitch approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha! That is much cleaner, and I completely missed it. Nice catch.

@rucoder @OhmSpectator
Avoid nil dereference in baseosmgr
91b89c0 
- avoid nil dereference

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
@OhmSpectator OhmSpectator force-pushed the rucoder/nil-in-downloader branch from 35b570b to 91b89c0 Compare January 30, 2025 17:35
@github-actions github-actions bot requested a review from deitch January 30, 2025 17:36
eriknordmark
eriknordmark approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OhmSpectator OhmSpectator merged commit 6bac1ef into lf-edge:master Jan 31, 2025
44 of 59 checks passed
@OhmSpectator
Copy link
Member

@rucoder backports to 13.4 and 12.0 are awaited :)

@OhmSpectator
Copy link
Member

  • backport to 13.4
  • backport to 12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknordmark eriknordmark eriknordmark approved these changes

@OhmSpectator OhmSpectator OhmSpectator approved these changes

@deitch deitch deitch approved these changes

Assignees
No one assigned
Labels
stable Should be backported to stable release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rucoder @OhmSpectator @deitch @eriknordmark