-
Notifications
You must be signed in to change notification settings - Fork 1
Update the target platform to 2024-03, Xtext 2.34, Klighd 3.0.1, and ELK 0.9.1 #65
Update the target platform to 2024-03, Xtext 2.34, Klighd 3.0.1, and ELK 0.9.1 #65
Conversation
Here is the problem that this PR currently has: Beginning with klighd 3.0.X klighd.lsp is no longer an Eclipse plugin but is only published to maven central. Hence, the language server build should be a maven only build that does not utilize maven tycho. @a-sr could you point me (or anyone who wants to upgrade Klighd) to your commits that implemented this change in the kieler/semantics? |
Also Sprotty 0.9.0 (the last version we mirrored as a p2 update site) still depends on javax, hence, we cannot remove javax from the build just yet without adopting a different way of buildin the LS. I guess, we could also build the language server via gradle now, right? |
@lhstrh Any idea why the ui tests fail for Epoch? Can you see the logs? |
Log of the runner
|
I don't understand the log. Is there a way to fix this? |
@lhstrh I have not the slightest idea how your test infrastructure works, so yes there might be a solution but I do not know it. |
@lhstrh Can this be an issue of the runner?
|
The semantics repository adapted to using the Maven structure during the last release, that was mainly done in this PR. It also does some restructuring of the language server for better debuggability of the LS from Eclipse, especially because the semantics uses other own Eclipse Plug-Ins in its language server. As I understand that might not be necessary here, as this repo does not contain the language server, but only the Eclipse application. The semantics repository updated to the 2024-03 release, so you might not want to use the 2023-12 release anymore, or if you want use the corresponding XText version from there. In the changes in the target platform in PR 97 you can also see how I needed to include an older update site in there to keep the JUnit4 tests working. You can either adapt that or switch to JUnit5 (which would cause other issues from my memory). |
Hmm, it's that JavaSe-21 error again. When testing the build locally, I only get the following error:
Maybe I am missing part of the dependencies to build everything on my machine. @lhstrh can you run the build for Linux or Windows to check this? |
@lhstrh I guess the issue is with the macos runner then. |
The macos build has the following output:
Why does it use Java 21 if the build apparently this to use 17? |
Also remove maven nature from org.lflang plugin to avoid deadline in build (in eclipse).
I am not quite sure why there are so many dependencies in here. Usually here should be only a few specified dependencies. Also jakarta does not seem to be used. But maybe it is a transient dependency that has been made explicit.
I test this later and I am not sure how we would start the LS in a developer setup anymore from Eclipse.
ab5c20a
to
c22b563
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks, @soerendomroes!
Remove runner debug settings before merging