Librarify #50
Draft
Librarify #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanneberger
reviewed
Mar 4, 2024
| @@ -1,5 +1,5 @@ | |||
| [package] | |||
| name = "lingua-franca" | |||
| name = "lingo" | |||
There was a problem hiding this comment.
I would leave it as lingua-franca because we still want to squat that name on crates.io ;D
tanneberger
reviewed
Mar 4, 2024
| ConfigFile::from(path) | ||
| .map_err(|err| println!("Error while reading Lingo.toml: {}", err)) | ||
| ConfigFile::from(path, Box::new(do_read_to_string)) | ||
| .map_err(|err| log::error!("Error while reading Lingo.toml: {}", err)) |
There was a problem hiding this comment.
if we now want to switch to a proper logging library, we probably need some non-standard schema.
TODO: cherry-pick this change out to a new branch
tanneberger
reviewed
Mar 13, 2024
| @@ -7,6 +7,7 @@ use std::path::PathBuf; | |||
| #[clap(rename_all = "lowercase")] | |||
| pub enum TargetLanguage { | |||
| C, | |||
| CCpp, | |||
|
we probably should setup a github action which checks if lingo still can be compiled into wsm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to use parts of the Lingo code base in WebAssembly.
This PR is very experimental. It is also quite small, so the stakes are low here, and there isn't a big rush to get this merged.
The changes here are sufficient to a) compile this to WASM without errors, and b) make it easy to get the JSON build properties for a given LF file from JS/TS.
More changes would be required in order to make all of the functionality of Lingo work without panics; this is because apparently the norm in the Rust ecosystem is to panic at runtime when encountering an operation that doesn't support WASM instead of using Cargo features, which would result in compile-time errors.