Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Docker image for Python changed to Alpine #2413

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Sep 29, 2024

Fixes #2379.

@lhstrh lhstrh added the enhancement Enhancement of existing feature label Sep 29, 2024
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no knowledge about this so can't provide a meaningful review.

@lhstrh lhstrh added the docker Issue related to the docker support label Sep 29, 2024
@lhstrh lhstrh merged commit 4b2b3c9 into master Sep 29, 2024
24 checks passed
@lhstrh lhstrh deleted the python-alpine branch September 29, 2024 23:32
@Depetrol
Copy link
Collaborator

This looks good to me. The meaningful change here is using Dash instead of Bash as the shell in the image, but this change doesn't affect the user interface since all docker image files are generated. Since all tests have passed, I think this is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Issue related to the docker support enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from python:3.10-slim to python:3.10-alpine default base image
3 participants