Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Docker image for Python changed to Alpine #2413

Merged
merged 1 commit into from
Sep 29, 2024
+1 −10
Merged

Default Docker image for Python changed to Alpine #2413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions core/src/main/java/org/lflang/generator/docker/PythonDockerGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* @author Hou Seng Wong
*/
public class PythonDockerGenerator extends CDockerGenerator {
public static final String DEFAULT_BASE_IMAGE = "python:3.10-slim";
public static final String DEFAULT_BASE_IMAGE = "python:3.10-alpine";

public PythonDockerGenerator(LFGeneratorContext context) {
super(context);
Expand All @@ -20,15 +20,6 @@ public String defaultImage() {
return DEFAULT_BASE_IMAGE;
}

@Override
protected String generateRunForInstallingDeps() {
if (builderBase().equals(defaultImage())) {
return "RUN set -ex && apt-get update && apt-get install -y python3-pip && pip install cmake";
} else {
return "# (Skipping installation of build dependencies; custom base image.)";
}
}

@Override
protected String generateCopyOfExecutable() {
var lfModuleName = context.getFileConfig().name;
Expand Down
Loading