Docker compose also create bin directory if not present #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lhstrh I saw this from trying to merge the Zephyr stuff. I am not sure whether it addresses the macOS failure since I havent yet seen the log output from the failed test(s) |
lhstrh
approved these changes
Apr 3, 2024
core/src/main/java/org/lflang/generator/docker/DockerComposeGenerator.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue where the docker compose generator fails to create the launcher because the bin directory was cleaned and is not present. I might only have surfaced now due to Peter making sure we checked the return value from the docker tests. (I am not sure because I did not look at those changes though)