Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report error when receiving DNET signals #296

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Conversation

byeonggiljun
Copy link
Collaborator

This PR includes an ad-hoc handling of DNET signals. Federates read the bytes from the socket and do nothing with the information.

Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo a small suggestion, let's get this merged so that we can merge the DNET changes in master.

src/core/federation.ts Outdated Show resolved Hide resolved
Co-authored-by: Edward A. Lee <eal@eecs.berkeley.edu>
@byeonggiljun
Copy link
Collaborator Author

Thank you, @edwardalee! I'll merge this.

@byeonggiljun byeonggiljun merged commit e2b569f into master Oct 18, 2024
4 checks passed
@byeonggiljun byeonggiljun deleted the dnet-ad-hoc branch October 18, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants