-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create proper Error strategy #46
Comments
🎉 This issue has been resolved in version 1.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Just merged the PR that implements this. Honestly, for the current scope of this project (as of this writing), this felt a bit overkill for me. Usually I would wait for the need to show itself, or any evidence that we will indeed need it the near future. And currently we don't have evidence showing that's the case. We only have a handful of errors and they are pretty much just used once in the codebase, so the abstraction didn't prove itself just yet hence why my feeling of this being an abstraction for abstraction sake, which I don't like (make the codebase more complex and harder to understand at first). But in any real world project, it's likely we would eventually reach an stage where the abstraction would pay off (errors being thrown / caught in different places). Ideally I would wait for that stage before engineering this upfront but then again I wanted to show of my train of thought here for the sake of the interview 🙂 . |
With error codes, helpful debugging errors and also user-friendly errors that can be translated in the future
Remember to update the dev docs with it
The text was updated successfully, but these errors were encountered: