Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide which unit testing framework to use and set it up #6

Closed
lfilho opened this issue Jun 11, 2020 · 3 comments · Fixed by #39
Closed

Decide which unit testing framework to use and set it up #6

lfilho opened this issue Jun 11, 2020 · 3 comments · Fixed by #39

Comments

@lfilho
Copy link
Owner

lfilho commented Jun 11, 2020

Initial thoughts:

  • Jest for unit testing and main driver
  • Playwright for driving a browser and actually testing the extension -- I read somewhere recently that an extension can't be tested headless, so we would need a headful driver.
    • This might impact our ability to automatically test the extension via CI, meaning the automate tests would have to run in a developer's machine, or in a more expensive CI setup (one with a X / window manager available so we can install and run full browser in there)
@lfilho lfilho added this to the Project scaffolding milestone Jun 11, 2020
@lfilho
Copy link
Owner Author

lfilho commented Jun 11, 2020

Remember to update eslint config when decided: https://eslint.org/docs/user-guide/configuring#specifying-environments

@lfilho lfilho changed the title Decide which testing framework to use and set it up Decide which unit testing framework to use and set it up Jun 12, 2020
@lfilho
Copy link
Owner Author

lfilho commented Jun 12, 2020

e2e testing (playwright or similar) is too big of a scope for this ticket. I have created another one to tackle that in particular: #38 .
In this one, I'll focus on unit tests only.

And for unit tests, I decided to go with Jest -- merely for having experience with it and having a nice CLI interface. :)

@lfilho
Copy link
Owner Author

lfilho commented Jun 14, 2020

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant