Feat: Add support single commits and PR body and tittle as commit message #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tykeal
requested changes
Aug 6, 2024
- Support USE_PR_AS_COMMIT flag, allows commit message to be replaced the pull request body and tittle. Note: the 50/72 rule of the title and body needs to be taken care of by the developer or the pre-commit verify would fail. - Comment the PR URL link alone with the workflow run URL on the Gerrit change request using `ssh gerrit review` CLI. This is useful to Jenkins jobs to query comments on the change and search for PR-### URL therefore allow developer comments to be sync back to the pull request on Github. - Prefix the git-review topic with the project name followed by PR-### to ensure same topic does not overused from diff projects under the same organization. - Update docs and examples caller workflows accordingly. Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Each commit in the pull request are processed individually as a single commit before submitting to Gerrit repository. This option allows you to preserve git history. This requires `inputs.SUBMIT_SINGLE_COMMITS` to be set to 'true' from the caller. Remove extra inputs. Gerrit server and port and project has be read from .gitreview file. Composite actions have a limitation on the number of the inputs that can be passed to 10. Update doc example with new feat options. Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
askb
commented
Aug 7, 2024
tykeal
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit in the pull request is processed individually as a
single commit before submitting to Gerrit repository. This option
allows you to preserve git history. This requires
inputs.SUBMIT_SINGLE_COMMITSto be set to 'true'from the caller.
Remove extra inputs. Gerrit server and port and the project must be read
from .gitreview file. Composite actions are limited on
the number of inputs that can be passed to 10.
Support USE_PR_AS_COMMIT flag, allows commit message to be
replaced the pull request body and title.
Note: the 50/72 rule of the title and body needs to be taken
care of by the developer or the pre-commit verification would fail.
Comment the PR URL link along with the workflow run URL on the
Gerrit change request using
ssh gerrit reviewCLI. This isuseful to Jenkins jobs to query comments on the change and search
for PR-### URL therefore allow developer comments to be sync back
to the pull request on Github.
Prefix the git-review topic with the project name followed by
PR-### to ensure the same topic is not overused from different projects
under the same organization.
Update docs and examples caller workflows accordingly.