Fix: if condition to check file ext

Fix condition to check the file extension with packer build script. The packer init steps gets skipped when the condition fails with some filenames ex: mininet-ovs-2.8.pkr.hcl. Issue: RELENG-5574 Change-Id: I91b3b6270c62ee3a2c8f28c25be22b408657d840 Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
lfit · Oct 2, 2024 · 377006d · 377006d
1 parent 72fac95
commit 377006d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/releasenotes/notes/fix-if-condition-791277d5b3aae6fe.yaml b/releasenotes/notes/fix-if-condition-791277d5b3aae6fe.yaml
@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    Fix condition that check the file extension with packer build script.
+    The condition is skipped when long names ex: mininet-ovs-2.8.pkr.hcl
diff --git a/shell/packer-build.sh b/shell/packer-build.sh
@@ -53,7 +53,7 @@ export PACKER_LOG="yes"
 export PACKER_LOG_PATH="$PACKER_BUILD_LOG"
 
 # download plugins only for HCL format
-if [[ "${template_file#*.}" == "pkr.hcl" ]]; then
+if [[ "${template_file#*.}" =~ .*pkr.hcl ]]; then
     echo "packer init ${template_file} ..."
     packer.io init "${template_file}"
 fi