Skip to content

Commit

Permalink
Fix: Remove stale opensdk version pinning
Browse files Browse the repository at this point in the history
Issue: RELENG-5176
Change-Id: Id6dd1fdac68e3105f938a225c67ca0bed6813f89
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
  • Loading branch information
ModeSevenIndustrialSolutions committed Feb 28, 2024
1 parent 2c01d1c commit bafd57c
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Ignore nodejs dir created by linting tools
node_modules/

# Ignore Vim temporary files
.*.sw?

Expand Down
6 changes: 6 additions & 0 deletions releasenotes/notes/lftools-update-3a7aa65b76b0cfc0.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
fixes:
- |
Remove Openstack SDK version pinning from shell scripts.
This will now be handled by the other modules as a declared
dependency. The previous version pin was extremely old.
3 changes: 0 additions & 3 deletions shell/openstack-cleanup-old-images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,9 @@ echo "---> Cleanup old images"
# shellcheck disable=SC1090
source ~/lf-env.sh

# TODO: "openstacksdk<0.99" AttributeError: 'Image' object has no
# attribute 'protected'
lf-activate-venv --python python3 "lftools[openstack]" \
kubernetes \
niet \
"openstacksdk<0.99" \
python-heatclient \
python-openstackclient \
python-magnumclient \
Expand Down
1 change: 0 additions & 1 deletion shell/python-tools-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ if [[ ! -f /tmp/pre-build-complete ]]; then

echo "Generating Requirements File"
cat << 'EOF' > "$requirements_file"
openstacksdk<0.99
python-heatclient
python-openstackclient
python-magnumclient
Expand Down

0 comments on commit bafd57c

Please sign in to comment.