Fix: Remove stale opensdk version pinning

Issue: RELENG-5176 Change-Id: Id6dd1fdac68e3105f938a225c67ca0bed6813f89 Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
lfit · Feb 28, 2024 · bafd57c · bafd57c
1 parent 2c01d1c
commit bafd57c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,6 @@
+# Ignore nodejs dir created by linting tools
+node_modules/
+
 # Ignore Vim temporary files
 .*.sw?
 

diff --git a/releasenotes/notes/lftools-update-3a7aa65b76b0cfc0.yaml b/releasenotes/notes/lftools-update-3a7aa65b76b0cfc0.yaml
@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Remove Openstack SDK version pinning from shell scripts.
+    This will now be handled by the other modules as a declared
+    dependency. The previous version pin was extremely old.
diff --git a/shell/openstack-cleanup-old-images.sh b/shell/openstack-cleanup-old-images.sh
@@ -14,12 +14,9 @@ echo "---> Cleanup old images"
 # shellcheck disable=SC1090
 source ~/lf-env.sh
 
-# TODO: "openstacksdk<0.99" AttributeError: 'Image' object has no
-# attribute 'protected'
 lf-activate-venv --python python3 "lftools[openstack]" \
     kubernetes \
     niet \
-    "openstacksdk<0.99" \
     python-heatclient \
     python-openstackclient \
     python-magnumclient \

diff --git a/shell/python-tools-install.sh b/shell/python-tools-install.sh
@@ -43,7 +43,6 @@ if [[ ! -f /tmp/pre-build-complete ]]; then
 
     echo "Generating Requirements File"
     cat << 'EOF' > "$requirements_file"
-openstacksdk<0.99
 python-heatclient
 python-openstackclient
 python-magnumclient