CI: Add rtdv3 verify callable reusable workflow #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwagantall
force-pushed
the
docs-reusable
branch
from
ea008f8
to
e019f39
Compare
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
jwagantall
force-pushed
the
docs-reusable
branch
from
e019f39
to
aba74dc
Compare
ModeSevenIndustrialSolutions
approved these changes
Aug 15, 2023
tykeal
requested changes
Aug 15, 2023
There was a problem hiding this comment.
Two things:
- Repo linting should be something that is done in repo specific GHA IMO
- This job should be done in the project specific .github repo using a workflow_dispatch job handler and not a workflow_call handler (which is used by reusable workflows). You already have an RTD verify reusuable workflow, but you're trying to add it into the testing in ONAP right now.
|
Thanks Andy, yes.. for now we are just adding it to the doc repo in ONAP to confirm it works, but eventually this workflow should live in the .github repo I wonder if I am making a redundant move by creating this workflow here actually.. but let me move it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.