[Backport] Variable as a method parameter might be overridden by the loop #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and bundle folder contains any other files
…ub category to the same level as parent
…ub category to the same level as parent
- (build 2.1.13.011)
[thunder] MAGETWO-90925: Wrong case in classname CLI in ProcessCronQueueObserver -[MAGETWO-90925] (https://jira.corp.magento.com/browse/MAGETWO-90925) Wrong case in classname CLI in ProcessCronQueueObserver
Merge branch '2.1' of github.com:magento/magento2ce into 2.1.14-develop-update
[TSG] Backporting for 2.1 (pr53) (2.1.14)
….1.14-develop-update
…update [Plankton] Merge release to 2.1.14-develop
(build 2.1.14.013)
…onths` to show more than 1 month (cherry picked from commit 54e1a71)
…ento#16287 - Merge Pull Request magento#16287 from chirag-wagento/magento2:overlapping-issue-backport - Merged commits: 1. c601b84
…mage/calendar when setting \`numberOfM… magento#16280 - Merge Pull Request magento#16280 from vasilii-b/magento2:MAGETWO-61209-calendar-widget-number-of-months_mage21 - Merged commits: 1. ce38bc8
…y[] = works faster than invoking functions in PHP
…ing admin login attempts cleanup magento#16347 - Merge Pull Request magento#16347 from rogyar/magento2:2.1-captcha-reset-admin-it - Merged commits: 1. d8cab67
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
… name magento#16577 - Merge Pull Request magento#16577 from mageprince/magento2:2.1-develop-PR-port-16515 - Merged commits: 1. 50364d1 2. 3156f06 3. 320748c 4. 2ea290a 5. fff72b6 6. 534e755 7. bf502d4 8. c5a77ff 9. 154cde1 10. c65e4d7 11. c34bc82 12. 835372f 13. e139ab4 14. 1f352cf 15. fec40bd 16. 09e2e5b 17. 1756134 18. 8af67d8 19. 5b353f4 20. a1ccb20 21. 964e126 22. 331c07a 23. 7a475a7 24. 1bc1104 25. 4bf400d 26. 362b942 27. 1cbcd7c 28. ea49cd6 29. af5ca55 30. 562ad21 31. fbfdf47 32. 0f981cf 33. abdba4d 34. 63d0ff9 35. 4a4d5e3 36. d9f848f 37. 1f6d6a4 38. 6dafb79 39. cfdf23d 40. d219d1c 41. 5a11c63 42. a66dbfd 43. 613b07d
… name(Magento_Sales::order/creditmemo.phtml). magento#16586 - Merge Pull Request magento#16586 from mageprince/magento2:2.1-develop-PR-port-16481 - Merged commits: 1. e39ca3e
… name(Magento_Sales::order/creditmemo.phtml). magento#16586
Accepted Public Pull Requests: - magento#16577: [Backport] Declare module namespace before template path name (by @mageprince) - magento#16586: [Backport] Declare module namespace before template path name(Magento_Sales::order/creditmemo.phtml). (by @mageprince)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#16143
Description
Variable as a method parameter might be overridden by the loop.
Rename the variable in the loop let the code more readable.