Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump FluentAssertions from 6.12.0 to 6.12.2 #339

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Bump FluentAssertions from 6.12.0 to 6.12.2 #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41fe768
Bump FluentAssertions from 6.12.0 to 6.12.2
dependabot[bot] Nov 9, 2024
43460ee
Fixed test
lg2de Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/SimpleAccounting/Presentation/ImportBookingsViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
using System.Threading.Tasks;
using System.Windows.Forms;
using System.Windows.Input;
using JetBrains.Annotations;
using lg2de.SimpleAccounting.Abstractions;
using lg2de.SimpleAccounting.Extensions;
using lg2de.SimpleAccounting.Infrastructure;
Expand Down Expand Up @@ -68,12 +69,12 @@
public bool IsImportBroken => !this.ImportAccounts.Any();

/// <summary>
/// Gets the minimal date valid for selecting <see cref="StartDate"/>.
/// Gets the minimal date valid for selecting <see cref="StartDate" />.
/// </summary>
public DateTime RangeMin { get; }

/// <summary>
/// Gets the maximal date valid for selecting <see cref="StartDate"/>.
/// Gets the maximal date valid for selecting <see cref="StartDate" />.
/// </summary>
public DateTime RangeMax { get; }

Expand Down Expand Up @@ -173,7 +174,7 @@

protected IProjectData ProjectData { get; }

private ulong FirstBookingNumber { get; }
[UsedImplicitly] internal ulong FirstBookingNumber { get; }

protected void UpdateIdentifierInLoadedData()
{
Expand Down Expand Up @@ -230,7 +231,7 @@
}
}

[SuppressMessage(

Check warning on line 234 in src/SimpleAccounting/Presentation/ImportBookingsViewModel.cs

View workflow job for this annotation

GitHub Actions / build 

Do not suppress issues. (https://rules.sonarsource.com/csharp/RSPEC-1309)
"Minor Code Smell", "S2221:\"Exception\" should not be caught when not required by called methods",
Justification = "Exception while processing external file must not cause crash at all")]
internal void LoadFromBytes(byte[] bytes, string informationalFileName)
Expand Down
2 changes: 1 addition & 1 deletion tests/SimpleAccounting.IntegrationTests/SimpleAccounting.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<ItemGroup>
<!-- license is apache 2.0 -->
<PackageReference Include="FluentAssertions" Version="6.12.0" />
<PackageReference Include="FluentAssertions" Version="6.12.2" />
<!-- license is MIT -->
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
<!-- license is BSD-3-Clause -->
Expand Down
2 changes: 1 addition & 1 deletion tests/SimpleAccounting.UnitTests/Presentation/ShellViewModelTests.Commands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ public void ImportBookingsCommand_BookingNumberInitialized()
FirstBookingNumber = 1,
RangeMin = new DateTime(DateTime.Now.Year, 1, 1, 0, 0, 0, DateTimeKind.Local),
RangeMax = new DateTime(DateTime.Now.Year, 12, 31, 0, 0, 0, DateTimeKind.Local)
});
}, o => o.IncludingInternalProperties());
vm.ImportAccounts.Should().NotBeEmpty();
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/SimpleAccounting.UnitTests/SimpleAccounting.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<ItemGroup>
<!-- license is apache 2.0 -->
<PackageReference Include="FluentAssertions" Version="6.12.0" />
<PackageReference Include="FluentAssertions" Version="6.12.2" />
<!-- license is MIT -->
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
<!-- license is BSD-3-Clause -->
Expand Down
Loading