Fix issue #380

[const-ae]

• Reset .Random.seed after impute::impute.knn is called

[lgatto]

I think you are missing a comma before the curly bracket

test_that("seed is not set by knn imputation method" {

But well done for adding a unit test!

[const-ae]

Oh yeah, you are right. I fixed the issue in my fork. Do I have to make a new pull request or does Github automatically see the new commit?

[codecov-io]

Codecov Report

Merging #381 into master will increase coverage by <.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   71.36%   71.36%   +<.01%     
==========================================
  Files          82       82              
  Lines        8280     8284       +4     
==========================================
+ Hits         5909     5912       +3     
- Misses       2371     2372       +1

Impacted Files	Coverage Δ
R/imputation.R	94.5% <80%> (-0.9%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69627bc...3f35996. Read the comment docs.

[sgibb]

@const-ae Great that you find such an error and created a PR. I have a few minor suggestions.

[sgibb]

Thanks for the changes. Could you please add an entry in the NEWS.md file (with a short description of the problem, a reference to the issue/PR and your name)?

[const-ae]

Thanks for helping me make a good PR.
I have updated the NEWS.md file, but do I need to do anything to generate the NEWS file or this done somewhere internally?

[sgibb]

Great thanks! (The NEWS file is generated automatically by a .git/hook (which we all have locally, so if any one of us will create a commit the NEWS file will be updated, if you are interested in something like that please have a look at: maker setup-git-hooks)

[const-ae]

Thanks, for the pointer. It looks like a quite useful project, but I have to admit I am still slightly intimidated by all the make stuff ;)

[lgatto]

Thank you both for the PR and the code review!