Skip to content

Conversation

sim0nsen
Copy link

@sim0nsen sim0nsen commented Apr 7, 2022

I'm not sure what the format of the script should be in order to support both docker and executing it directly from python. But this is an initial idea :)

@lgc-4
Copy link
Owner

lgc-4 commented Dec 5, 2022

Sorry for the late response, I kind of forgot about this project.

Generally looks good so far but I dislike the Idea of reading the config from environment variables. It's great for docker but kind of terrible if you want to run it as a normal python script without the docker container. Maybe use command line parameters instead?

Also, feel free to add yourself to the list of contributors at the top of the script and bump the version, something like

    #################################
    ##                             ##
    ##     one.com DDNS Script     ##
    ##                             ##
    #################################
    | Version      | 2.4            |
    +--------------+----------------+
    | Last Updated | 2022-12-05     |
    +--------------+----------------+

    +----------------+-------------------------+
    | Initial Author | Lugico <main@lugico.de> |
    +----------------+-------------------------+
    | Contributors   | Vigge                   |
    |                | sim0nsen                |
    +----------------+-------------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants