Wrap gi.require with assert in class.lua and ffi.lua #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes lgi-devs#71 Calling gi.require may not always succeed. If we do not wrap it in an `assert`, we will get confusing error messages. For example, a failure in `lgi/ffi.lua` would look like: attempt to index local 'gobject' (a boolean value) wrapping `gi.require` with `assert` instead would show a more informative message: Typelib file for namespace 'win32', version '1.0' not found This change updates both `lgi/class.lua` and `lgi/ffi.lua` which appear to be the only two files in the codebase that do not wrap `gi.require` with an `assert`.
|
Seems convincing enough. Thanks!
Sorry for not doing either of that. 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Calling gi.require may not always succeed. If we do not wrap it in an
assert, we will get confusing error messages.For example, a failure in
lgi/ffi.luawould look like:wrapping
gi.requirewithassertinstead would show a more informative message:This change updates both
lgi/class.luaandlgi/ffi.luawhich appear to be the only two files in the codebase that do not wrapgi.requirewith anassert.A practical example where this would have been useful is NixOS/nixpkgs#139159 (comment)
I actually managed to figure out the issue with NixOS using this patch.
Thanks for developing and maintaining lgi!