Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install libreadline-dev on CI #332

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

luau-project
Copy link
Contributor

Description

Recently, GitHub updated their Ubuntu runners labeled as ubuntu-latest to run under Ubuntu 24.04.

Note

Previously, ubuntu-latest ran on Ubuntu 22.04.

Due this change, the package libreadline-dev is not installed anymore by default, causing the current (Ubuntu) CI to fail while building Lua even for unrelated changes (notably #331), because readline is missing in the system.

Changes

  • Added a step to install libreadline-dev before the build of Lua on (Ubuntu) CI;
  • Minor edits in the (Ubuntu) CI regarding the LUA_VERSION environment variable;
  • Updated MSVC CI to use the latest LuaInstaller version to install Lua (Release notes).

@luau-project luau-project marked this pull request as draft December 26, 2024 08:53
.github/workflows/msvc-ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@luau-project
Copy link
Contributor Author

This PR is on hold for now. On my personal fork just before opening the PR (with a small modification to CI run on any branch), I didn't get any issue (check https://github.com/luau-project/lgi/actions/runs/12501449208).

There seems to be some strange behavior going on Mesa VK, which I'm searching on the internet.

@luau-project
Copy link
Contributor Author

Update

TLDR;

the solution is to force software rendering on CI.

In-depth explanation

Note

In my fork, even though the jobs were running on images defined as ubuntu-latest, they were in fact ran on Ubuntu 22.04 (GitHub is in the transition process). This is the reason I didn't catch the error on my fork's CI.

Analyzing the upstream discussion at https://gitlab.freedesktop.org/mesa/mesa/-/issues/10293, and inspecting the diffs of related merges https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27836/diffs, I found that forcing software rendering on Ubuntu 24.04 would solve the problem.

Thus, at top, the following excerpt forces software rendering.

env:
  # Force software rendering on CI, because
  # we were getting a CI error on Ubuntu 24.04 as follows:
  #   MESA: error: ZINK: vkCreateInstance failed (VK_ERROR_INCOMPATIBLE_DRIVER))
  # For more information, see https://github.com/lgi-devs/lgi/pull/332
  LIBGL_ALWAYS_SOFTWARE: 1

As you can see, it worked fine on Ubuntu 24.04 https://github.com/lgi-devs/lgi/actions/runs/12502953910/job/34882613489#step:1:4.

In my view, the PR is ready for review.

@luau-project luau-project marked this pull request as ready for review December 26, 2024 11:01
@psychon psychon merged commit 8e49fba into lgi-devs:master Dec 27, 2024
15 checks passed
@psychon
Copy link
Collaborator

psychon commented Dec 27, 2024

Thanks for investigating and fixing this!

@luau-project luau-project deleted the fix-ubuntu-ci branch December 27, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants