Skip to content
This repository has been archived by the owner on Jan 26, 2018. It is now read-only.

Notification support #4

Open
donny-dont opened this issue Jan 27, 2016 · 2 comments
Open

Notification support #4

donny-dont opened this issue Jan 27, 2016 · 2 comments

Comments

@donny-dont
Copy link

Would be great if maintainers were notified through Slack when a pull request they need to review is opened.

jonbodner pushed a commit to jonbodner/lgtm that referenced this issue Jun 17, 2016
rfc3339 timestamp is now modified to use . instead of : and not have …
@samber
Copy link

samber commented Jul 7, 2016

I don't know the work that have been made on this, but I would suggest that notifying through Hubot would allow to connect to every Slack-like providers !

@bradrydzewski
Copy link
Member

There hasn't been much work one notifications. I have created the interface to define how lgtm can invoke notification services: https://github.com/lgtmco/lgtm/blob/master/notifier/sender.go

I envision having a small number of built-in notification capabilities such as:

  • github notification. comment on the pull request and @ mention the reviewers
  • http webhook notification

The http webhook should be enough to let teams come up with any sort of custom notification workflow they want using which ever services they prefer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants