Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed vm context #2

Merged
merged 2 commits into from
Mar 20, 2020
Merged

removed vm context #2

merged 2 commits into from
Mar 20, 2020

Conversation

irega
Copy link

@irega irega commented Mar 18, 2020 •
edited
Loading

Summary

Removed vm context instance member and used this.dom.getInternalVMContext() where it's needed instead to fix the memory leak as suggested in #9606

Test plan

Green CI with node >= 10.

@irega
Copy link
Author

irega commented Mar 18, 2020

@lamhieu-vk ready for review

@irega irega mentioned this pull request Mar 19, 2020
Merged
@lh0x00 lh0x00 merged commit e6ed90b into lh0x00:feature/UpgradeJsdom16 Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irega @lh0x00