Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAM TLEN should be 0 when either read is unmapped #373

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

jmarshall
Copy link
Contributor

Don't compute tlen when either r or r_next indicates unmapped. Fixes #365.

(Compiled, but I have not rigorously tested this.)

this_rid/this_pos will be copied from r_prev(=r_next)'s values when this
read is unmapped (i.e., r is NULL). In this case, we can write RNEXT as
'=' but should not calculate TLEN from these placeholder values.
Similarly when the mate is unmapped (i.e., r_next is NULL).

Fixes lh3#365.
@lh3 lh3 added the bug label Apr 5, 2019
@lh3 lh3 merged commit 371bc95 into lh3:master Apr 5, 2019
@lh3
Copy link
Owner

lh3 commented Apr 5, 2019

Thanks!

@jmarshall jmarshall deleted the unmapped-tlen branch April 5, 2019 14:02
@lh3 lh3 added this to the 2.17 milestone Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants